core: more compile time assertions and doc#48
Merged
tcoratger merged 3 commits intoleanEthereum:mainfrom Apr 8, 2026
Merged
Conversation
b-wagn
approved these changes
Apr 7, 2026
Contributor
b-wagn
left a comment
b-wagn
left a comment
There was a problem hiding this comment.
Thanks. Looks good, just minor comments. Maybe the one thing that is important is the comment about eprint vs CiC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@b-wagn I've checked with Claude, with the 2 papers as context, and it seems couple of const time assertions could be added with documentation to justify them.
I've checked all of them and they look legit, let me know what you think. They are free since done at compile time.